-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] Add support for BT Gateway switch on chuangmi.plug.212a01 #11657
Conversation
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
public static JsonElement getJsonElement(String element, JsonElement responseValue) | ||
throws ClassCastException, IllegalStateException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd better know before accessing it if it's the right type in the right state. Catching these is bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe I'm overly causious here.. as the responsevalue is something that comes from the device and can have rather unexpected values I normally rather have a friendly message than an ugly stacktrace.
That said, I think the code indeed has little chance to generate these errors even in case of strange inputs so i'll remove it
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com